packetbeat/module: fix upload of bundled ingest pipelines on Windows#41110
Merged
efd6 merged 1 commit intoelastic:mainfrom Oct 4, 2024
Merged
packetbeat/module: fix upload of bundled ingest pipelines on Windows#41110efd6 merged 1 commit intoelastic:mainfrom
efd6 merged 1 commit intoelastic:mainfrom
Conversation
c8b949e to
14d4cf3
Compare
Contributor
|
|
Detection of data stream identity was using os.PathSeparator which will not match the path separator used by embed.FS which is always "/"[1]. [1]https://pkg.go.dev/embed#hdr-Directives
14d4cf3 to
4fda8e8
Compare
Contributor
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
nicholasberlin
approved these changes
Oct 4, 2024
Contributor
|
Thanks for handling this. |
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
…41110) Detection of data stream identity was using os.PathSeparator which will not match the path separator used by embed.FS which is always "/"[1]. [1]https://pkg.go.dev/embed#hdr-Directives (cherry picked from commit f55bd8d)
Merged
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
…41110) Detection of data stream identity was using os.PathSeparator which will not match the path separator used by embed.FS which is always "/"[1]. [1]https://pkg.go.dev/embed#hdr-Directives (cherry picked from commit f55bd8d)
Merged
6 tasks
efd6
added a commit
that referenced
this pull request
Oct 4, 2024
…41110) (#41116) Detection of data stream identity was using os.PathSeparator which will not match the path separator used by embed.FS which is always "/"[1]. [1]https://pkg.go.dev/embed#hdr-Directives (cherry picked from commit f55bd8d) Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
efd6
added a commit
that referenced
this pull request
Oct 4, 2024
…41110) (#41115) Detection of data stream identity was using os.PathSeparator which will not match the path separator used by embed.FS which is always "/"[1]. [1]https://pkg.go.dev/embed#hdr-Directives (cherry picked from commit f55bd8d) Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detection of data stream identity was using os.PathSeparator which will not match the path separator used by embed.FS which is always "/"[1].
[1]https://pkg.go.dev/embed#hdr-Directives
Proposed commit message
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs